Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify queue processor about cross cluster tasks #4328

Merged
merged 3 commits into from
Jul 28, 2021

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Jul 26, 2021

What changed?

  • Notify queue processor about cross-cluster tasks

Why?

  • Need to trigger a DB load for cross-cluster tasks when they are generated

How did you test it?

Potential risks

Release notes

Documentation Changes

@yycptt yycptt requested a review from demirkayaender July 26, 2021 17:21
@coveralls
Copy link

coveralls commented Jul 26, 2021

Pull Request Test Coverage Report for Build a2726281-9fc9-45c9-82c3-fa2d52aa554b

  • 8 of 26 (30.77%) changed or added relevant lines in 2 files are covered.
  • 59 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.05%) to 56.793%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/history/historyEngine.go 5 23 21.74%
Files with Coverage Reduction New Missed Lines %
service/history/execution/mutable_state_task_refresher.go 1 74.4%
common/persistence/historyManager.go 2 66.33%
common/task/fifoTaskScheduler.go 2 85.57%
common/task/weightedRoundRobinTaskScheduler.go 2 89.12%
common/types/mapper/thrift/shared.go 2 64.98%
service/matching/matcher.go 2 91.46%
common/cache/lru.go 3 90.73%
common/persistence/dataManagerInterfaces.go 3 64.83%
service/history/queue/timer_gate.go 3 95.83%
common/persistence/nosql/nosqlExecutionStore.go 9 57.52%
Totals Coverage Status
Change from base Build 8b8ea82f-d3e8-40c9-a56c-235ca6e26f28: 0.05%
Covered Lines: 77890
Relevant Lines: 137146

💛 - Coveralls

@yycptt yycptt merged commit adbffa4 into cadence-workflow:master Jul 28, 2021
@yycptt yycptt deleted the notify-cross-cluster-task branch July 28, 2021 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants