Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deadlock in transfer queue processor #4337

Merged
merged 2 commits into from
Jul 30, 2021

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Jul 30, 2021

What changed?

  • Fix deadlock in transfer queue processor

Why?

  • Bug fix

How did you test it?

Potential risks

Release notes

Documentation Changes

@yycptt yycptt requested review from Shaddoll and a team July 30, 2021 19:00
@coveralls
Copy link

Pull Request Test Coverage Report for Build 91985806-de87-406a-8657-9b4031e37046

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • 40 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.007%) to 56.831%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/history/queue/transfer_queue_processor_base.go 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 1 88.6%
service/history/execution/mutable_state_task_refresher.go 1 74.4%
service/history/queue/transfer_queue_processor_base.go 2 79.54%
common/cache/lru.go 3 90.73%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 50.23%
common/task/fifoTaskScheduler.go 4 83.51%
service/history/task/transfer_active_task_executor.go 4 70.49%
common/persistence/nosql/nosqlplugin/cassandra/workflowUtils.go 8 78.09%
common/persistence/nosql/nosqlplugin/cassandra/workflowParsingUtils.go 14 88.1%
Totals Coverage Status
Change from base Build 851d367b-9da6-4a7a-8f2a-e5ea6fcf7f34: -0.007%
Covered Lines: 78008
Relevant Lines: 137262

💛 - Coveralls

@yycptt yycptt merged commit cd9a33a into cadence-workflow:master Jul 30, 2021
@yycptt yycptt deleted the fix-transfer-queue branch July 30, 2021 19:39
yycptt added a commit that referenced this pull request Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants