Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLI jwtKey NPE issue #4358

Merged
merged 2 commits into from
Aug 13, 2021
Merged

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Aug 13, 2021

What changed?

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

@yycptt yycptt requested a review from longquanzheng August 13, 2021 21:12
@coveralls
Copy link

coveralls commented Aug 13, 2021

Pull Request Test Coverage Report for Build d3ab68c0-0293-46b8-82f6-59e0355d03a6

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • 61 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.02%) to 56.324%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tools/cli/factory.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 1 89.64%
service/history/execution/mutable_state_task_refresher.go 1 74.4%
service/history/queue/timer_queue_processor_base.go 1 78.56%
common/persistence/executionManager.go 2 75.5%
common/persistence/statsComputer.go 2 95.71%
common/types/mapper/thrift/shared.go 2 64.98%
common/task/fifoTaskScheduler.go 4 82.47%
common/persistence/nosql/nosqlExecutionStore.go 9 57.52%
service/history/shard/context.go 9 65.23%
service/history/execution/context.go 14 66.93%
Totals Coverage Status
Change from base Build 2300446c-8199-4efd-8b4d-c649c07159cc: 0.02%
Covered Lines: 78471
Relevant Lines: 139320

💛 - Coveralls

@yycptt yycptt merged commit 8ea6a6a into cadence-workflow:master Aug 13, 2021
@yycptt yycptt deleted the fix-cli-jwtKey branch August 13, 2021 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants