Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix oauth yaml config #4360

Merged
merged 2 commits into from
Aug 14, 2021
Merged

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Aug 13, 2021

What changed?

  • Fix oauth yaml config

Why?
Without the change, service start will fail due to invalid config. Since development_oauth.yaml will be deep merged with development.yaml and cause archival config to be invalid.

➜  cadence (fix-oauth-config) ✗ ./cadence-server --zone oauth start
2021/08/13 15:17:20 Loading config; env=development,zone=oauth,configDir=./config
2021/08/13 15:17:20 Loading configFiles=[./config/base.yaml ./config/development.yaml ./config/development_oauth.yaml]
2021/08/13 15:17:20 config validation failed: Invalid history archival config

How did you test it?
Tested locally. With the change, server can pass the config validation phase.

Potential risks

Release notes

Documentation Changes

@yycptt yycptt requested a review from longquanzheng August 13, 2021 22:21
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6bf377a5-cc8f-4567-8dee-3c25544cf4b2

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 53 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.006%) to 56.301%

Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 1 89.64%
common/persistence/executionManager.go 2 75.5%
common/persistence/statsComputer.go 2 95.71%
common/persistence/nosql/nosqlExecutionStore.go 9 57.52%
service/history/shard/context.go 9 65.23%
service/history/execution/context.go 14 66.93%
common/persistence/sql/sqlExecutionStore.go 16 60.0%
Totals Coverage Status
Change from base Build 2300446c-8199-4efd-8b4d-c649c07159cc: -0.006%
Covered Lines: 78438
Relevant Lines: 139319

💛 - Coveralls

@longquanzheng longquanzheng merged commit a58b8b9 into cadence-workflow:master Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants