Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/simplify archival config validation #4366

Merged
merged 3 commits into from
Aug 26, 2021

Conversation

longquanzheng
Copy link
Contributor

@longquanzheng longquanzheng commented Aug 15, 2021

What changed?
Improve archival config validation

Why?
For #4361

How did you test it?
Unit tests

Potential risks
No

Release notes

Documentation Changes

@longquanzheng longquanzheng requested a review from yycptt August 15, 2021 21:00
@longquanzheng longquanzheng force-pushed the qlong-archival-validate branch from 11872fd to e6613aa Compare August 26, 2021 18:08
@github-actions github-actions bot force-pushed the qlong-archival-validate branch from da0bc90 to 58e663d Compare August 26, 2021 18:09
@longquanzheng longquanzheng changed the title Improve archival config validation Improve/simplify archival config validation Aug 26, 2021
@longquanzheng longquanzheng merged commit 45c7b4c into master Aug 26, 2021
@longquanzheng longquanzheng deleted the qlong-archival-validate branch August 26, 2021 18:54
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5acfe373-4d40-4ad9-82f6-fff791464145

  • 16 of 16 (100.0%) changed or added relevant lines in 1 file are covered.
  • 38 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.06%) to 56.534%

Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 1 89.64%
service/history/queue/timer_queue_processor_base.go 1 78.56%
client/history/client.go 2 41.25%
client/history/metricClient.go 2 47.05%
service/history/execution/mutable_state_builder.go 2 69.86%
service/history/handler.go 2 48.15%
service/history/queue/transfer_queue_processor.go 2 57.18%
service/frontend/workflowHandler.go 4 58.8%
common/task/fifoTaskScheduler.go 5 82.47%
common/persistence/nosql/nosqlExecutionStore.go 8 59.12%
Totals Coverage Status
Change from base Build 1560c792-cbd8-4996-9f1a-9f3912c0c6ae: 0.06%
Covered Lines: 79061
Relevant Lines: 139848

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants