Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose invalid timer value in the error message #4380

Merged

Conversation

demirkayaender
Copy link
Contributor

What changed?
Currently, if the timer has an invalid value; the error just says it's invalid. With this change, it will also tell the value of it.

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

@demirkayaender demirkayaender requested a review from a team August 17, 2021 22:43
Copy link
Contributor

@mkolodezny mkolodezny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

coveralls commented Aug 17, 2021

Pull Request Test Coverage Report for Build 007c367c-1444-4bd9-93cd-3adc3574ceee

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 100 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.06%) to 56.433%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/history/decision/checker.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
service/history/decision/checker.go 1 74.82%
common/task/fifoTaskScheduler.go 2 87.63%
common/task/weightedRoundRobinTaskScheduler.go 2 89.12%
common/types/mapper/thrift/shared.go 2 64.98%
service/history/execution/mutable_state_builder.go 2 69.92%
service/matching/matcher.go 2 91.46%
service/history/task/transfer_active_task_executor.go 4 70.62%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 6 49.77%
common/persistence/nosql/nosqlplugin/cassandra/workflowUtils.go 28 76.31%
common/persistence/nosql/nosqlplugin/cassandra/workflowParsingUtils.go 51 80.09%
Totals Coverage Status
Change from base Build a66335e4-f59b-46d7-a396-6d906ce9052d: -0.06%
Covered Lines: 78628
Relevant Lines: 139331

💛 - Coveralls

@demirkayaender demirkayaender merged commit 4781a8d into cadence-workflow:master Aug 18, 2021
@demirkayaender demirkayaender deleted the invalid_timer branch August 18, 2021 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants