Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failover metrics scope improve #4391

Merged
merged 3 commits into from
Aug 19, 2021
Merged

Conversation

yux0
Copy link
Contributor

@yux0 yux0 commented Aug 19, 2021

What changed?

  1. Fix graceful failover failure metrics
  2. Improve failover metrics scope initialization

Why?
Provide detail failover metrics with domain tags

How did you test it?

Potential risks

Release notes

Documentation Changes

@yux0 yux0 requested review from yycptt and a team August 19, 2021 17:59
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11633ff8-db79-4ddc-b34b-029ef657b680

  • 6 of 10 (60.0%) changed or added relevant lines in 2 files are covered.
  • 40 unchanged lines in 14 files lost coverage.
  • Overall coverage increased (+0.005%) to 56.439%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/domain/failover_watcher.go 2 4 50.0%
service/history/failover/coordinator.go 4 6 66.67%
Files with Coverage Reduction New Missed Lines %
common/domain/failover_watcher.go 1 61.67%
service/history/execution/mutable_state_task_refresher.go 1 74.4%
client/history/client.go 2 41.25%
client/history/metricClient.go 2 47.05%
common/persistence/historyManager.go 2 66.33%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
common/types/mapper/thrift/shared.go 2 64.98%
service/history/execution/mutable_state_builder.go 2 69.86%
service/history/handler.go 2 48.15%
service/matching/taskListManager.go 2 74.09%
Totals Coverage Status
Change from base Build 3963ea27-5204-4d7b-ad45-4bcec71b5360: 0.005%
Covered Lines: 78715
Relevant Lines: 139470

💛 - Coveralls

@yux0 yux0 merged commit 3255b7c into cadence-workflow:master Aug 19, 2021
@yux0 yux0 deleted the failover-metrics branch August 19, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants