Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor config methods for internal use #4448

Merged
merged 2 commits into from
Sep 3, 2021

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Sep 2, 2021

What changed?

  • Export config validate() and fillDefaults() methods for internal use since internal server is not using the Config struct
  • Move logic that will change persistence config values to pesistenceConfig.FillDefaults()

Why?

  • For internal server release

How did you test it?

  • Tested in internal testing cluster

Potential risks

  • N/A, logic is the same

Release notes

Documentation Changes

@yycptt yycptt requested review from longquanzheng and a team September 2, 2021 23:07
@coveralls
Copy link

coveralls commented Sep 2, 2021

Pull Request Test Coverage Report for Build ae5ea1d7-80a9-4964-935c-b733b62d6859

  • 28 of 29 (96.55%) changed or added relevant lines in 3 files are covered.
  • 73 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.02%) to 56.432%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/config/persistence.go 23 24 95.83%
Files with Coverage Reduction New Missed Lines %
common/config/persistence.go 1 84.91%
common/task/weightedRoundRobinTaskScheduler.go 1 89.64%
service/history/queue/timer_queue_processor_base.go 1 78.56%
service/history/execution/mutable_state_builder.go 2 69.9%
service/history/queue/timer_queue_processor.go 2 58.77%
common/persistence/serialization/parser.go 4 65.41%
common/persistence/serialization/thrift_decoder.go 4 59.6%
common/task/fifoTaskScheduler.go 5 84.54%
common/persistence/sql/workflowStateMaps.go 17 84.2%
common/persistence/serialization/getters.go 36 58.53%
Totals Coverage Status
Change from base Build 0fd3f657-6315-48df-9bce-1450181f788c: 0.02%
Covered Lines: 79525
Relevant Lines: 140923

💛 - Coveralls

@yycptt yycptt merged commit 9393737 into cadence-workflow:master Sep 3, 2021
@yycptt yycptt deleted the export-config-methods branch September 3, 2021 00:33
yycptt added a commit that referenced this pull request Sep 3, 2021
- Export config validate() and fillDefaults() methods for internal use
- Move logic that will change persistence config values to pesistenceConfig.FillDefaults()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants