Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix workflow refresh for closed workflows #4472

Merged
merged 6 commits into from
Sep 10, 2021
Merged

Fix workflow refresh for closed workflows #4472

merged 6 commits into from
Sep 10, 2021

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Sep 9, 2021 •
edited
Loading

What changed?

  • Allow workflow refresh for closed workflows
  • Remove duplicated/buggy GetCloseEvent() method in mutableState
  • Remove unused parameter from workflow refresher, task generator, mutableState and timerSequence
  • Handle get history client error when calling RefreshWorkflowTask
  • Remove defer() in CapturePanic() as this function is already called in defer

Why?

  • Bug fix for refresh closed workflows

How did you test it?

  • Tested locally

Potential risks

Release notes

Documentation Changes

@yycptt yycptt requested review from yux0 and longquanzheng September 9, 2021 17:14
@coveralls
Copy link

coveralls commented Sep 9, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 36639b4a-937e-4f57-8711-0cc271ee4c11

  • 11 of 25 (44.0%) changed or added relevant lines in 9 files are covered.
  • 47 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.03%) to 56.43%
Changes Missing Coverage Covered Lines Changed/Added Lines %
service/history/execution/mutable_state_task_refresher.go 1 2 50.0%
service/history/execution/state_rebuilder.go 1 2 50.0%
service/history/historyEngine.go 0 2 0.0%
client/history/client.go 0 3 0.0%
common/log/panic.go 1 8 12.5%
Files with Coverage Reduction New Missed Lines %
service/history/execution/mutable_state_builder.go 1 69.68%
common/task/fifoTaskScheduler.go 2 82.47%
service/history/execution/state_builder.go 2 70.96%
service/matching/taskListManager.go 2 74.09%
common/persistence/dataManagerInterfaces.go 3 60.91%
common/clock/time_source.go 7 37.5%
common/persistence/nosql/nosqlplugin/cassandra/tasks.go 14 72.8%
common/persistence/nosql/nosqlTaskStore.go 16 58.37%
Totals Coverage Status
Change from base Build d3aa7732-8ab7-47a3-b7a1-c8ede6838e03: -0.03%
Covered Lines: 79808
Relevant Lines: 141428
💛 - Coveralls

@yycptt yycptt merged commit c387b40 into cadence-workflow:master Sep 10, 2021
@yycptt yycptt deleted the fix-close-workflow-refresh branch September 10, 2021 19:22
yycptt added a commit that referenced this pull request Sep 10, 2021
@yycptt
Fix workflow refresh for closed workflows (#4472)
5dd7eb7 
- Allow workflow refresh for closed workflows
- Remove duplicated/buggy GetCloseEvent() method in mutableState
- Remove unused parameters from workflow refresher, task generator, mutableState, and timerSequence
- Handle get history client error when calling RefreshWorkflowTask
- Remove defer() in CapturePanic() as this function is already called in defer
@ceearrashee
Copy link

Hello!
The fix that you made did not include in the last releases.
Can you guide me on when this fix will be released and in which release?

@longquanzheng
Copy link
Contributor

@ceearrashee Hello, it's included in the next minor release branch: https://github.com/uber/cadence/commits/0.23.x
v0.23.0 is being baked and will be out soon. Stay tuned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longquanzheng longquanzheng longquanzheng approved these changes

@yux0 yux0 yux0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yycptt @coveralls @ceearrashee @longquanzheng @yux0