Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix record child completion error handling #4515

Merged
merged 4 commits into from
Sep 27, 2021

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Sep 27, 2021

What changed?

  • Fix record child completion error handling

Why?

  • Fix record child completion error handling

How did you test it?

  • Unit test

Potential risks

  • N/A

Release notes

Documentation Changes

@yycptt yycptt requested review from demirkayaender and a team September 27, 2021 17:30
@coveralls
Copy link

coveralls commented Sep 27, 2021

Pull Request Test Coverage Report for Build e2a70b79-4f30-4682-b3fa-5221507b3b9a

  • 9 of 11 (81.82%) changed or added relevant lines in 1 file are covered.
  • 119 unchanged lines in 23 files lost coverage.
  • Overall coverage decreased (-0.03%) to 56.449%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/history/task/transfer_active_task_executor.go 9 11 81.82%
Files with Coverage Reduction New Missed Lines %
service/history/execution/mutable_state_task_refresher.go 1 73.82%
client/history/client.go 2 40.74%
client/history/metricClient.go 2 45.94%
common/membership/rpServiceResolver.go 2 73.58%
common/persistence/executionManager.go 2 75.75%
common/persistence/statsComputer.go 2 96.43%
common/task/parallelTaskProcessor.go 2 92.48%
common/types/mapper/thrift/shared.go 2 64.65%
service/history/handler.go 2 47.76%
service/history/queue/transfer_queue_processor.go 2 57.76%
Totals Coverage Status
Change from base Build c21a7ab8-de4f-4628-b9d8-ea9b8fb9762b: -0.03%
Covered Lines: 80200
Relevant Lines: 142076

💛 - Coveralls

@yycptt yycptt merged commit a590cac into cadence-workflow:master Sep 27, 2021
@yycptt yycptt deleted the fix-record-child-complete branch September 27, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants