-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support DNS SRV Records within Ringpop #4614
Merged
longquanzheng
merged 6 commits into
cadence-workflow:master
from
lindleywhite:f-dns-srv-ringpop
Nov 10, 2021
Merged
Support DNS SRV Records within Ringpop #4614
longquanzheng
merged 6 commits into
cadence-workflow:master
from
lindleywhite:f-dns-srv-ringpop
Nov 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longquanzheng
approved these changes
Nov 9, 2021
Pull Request Test Coverage Report for Build f3484cc7-2d30-4150-9699-f5288b7521bf
💛 - Coveralls |
longquanzheng
pushed a commit
that referenced
this pull request
Nov 11, 2021
longquanzheng
pushed a commit
that referenced
this pull request
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to configure an additional DNS method to reference DNS SRV records. This allows the initial service discovery of services to lookup hosts based on SRV records instead of having fixed ports within the host configuration.
Cadence is required to have fixed ports when configuring it mainly because it is expected to be hosted on primary VMs. However, when you deploy Cadence to a containerized environment you may not be able to fix ports to hosts and would rather have dynamic discoverability.
The tests are supplied with the code. The code just extends what is already there.
The worst case would be that the net.DefaultResolver can not lookup SRV records and thus the server components erring out on startup.
Release notes
Cadence can now support DNS SRV records within the configuration.
Documentation Changes
This could be added as an option within the ringpop configuration. Please advise.