Add workflow query-types command to CLI
#5456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arzonus
changed the title
workflow query-types command to CLI
3vilhamster
reviewed
Nov 22, 2023
| @@ -629,6 +629,11 @@ func QueryWorkflowUsingStackTrace(c *cli.Context) { | |||
| queryWorkflowHelper(c, "__stack_trace") | |||
| } | |||
|
|
|||
| // QueryWorkflowUsingQueryTypes list all query types of the workflow using __query_types as query type | |||
| func QueryWorkflowUsingQueryTypes(c *cli.Context) { | |||
| queryWorkflowHelper(c, "__query_types") | |||
There was a problem hiding this comment.
This feature on the client side was not yet released and is not yet supported by java client.
I'm not sure what is the best way to communicate this.
There was a problem hiding this comment.
I think that's fine to have CLI doing more than you can do programmatically.
There was a problem hiding this comment.
it is, but it's also implying [something] will work.
what's the failure message when this reaches a worker that doesn't support the query? it should probably be something more descriptive than a default one.
dkrotx
approved these changes
Nov 22, 2023
| @@ -629,6 +629,11 @@ func QueryWorkflowUsingStackTrace(c *cli.Context) { | |||
| queryWorkflowHelper(c, "__stack_trace") | |||
| } | |||
|
|
|||
| // QueryWorkflowUsingQueryTypes list all query types of the workflow using __query_types as query type | |||
| func QueryWorkflowUsingQueryTypes(c *cli.Context) { | |||
| queryWorkflowHelper(c, "__query_types") | |||
There was a problem hiding this comment.
I think that's fine to have CLI doing more than you can do programmatically.
arzonus
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
sankari165,
taylanisikdemir and
demirkayaender
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new command
workflow query-typeshas been added.Why?
The command will allows users to retrieve the list of available query types. #382
How did you test it?
It has been tested locally.
Potential risks
No potential risks, the existing functionality hasn't been touched.
Release notes
Documentation Changes
cadence-workflow/Cadence-Docs#168