Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade domain_config type in cassandra schema to add async wf config #5630

Conversation

taylanisikdemir
Copy link
Member

@taylanisikdemir taylanisikdemir commented Jan 26, 2024

What changed?
Updated domain_config type in cassandra schema to include async workflow config blob. This is needed to be able to persist per domain async workflow configs. The layers doing data conversion also needed to be updated.

Past relevant PRs:

How did you test it?

  1. Create new image locally
    ./scripts/buildkite/docker-build.sh

  2. Run default docker compose
    docker-compose -f docker-compose.yml up

  3. Test e2e via cli

# create a new domain
go run cmd/tools/cli/main.go --domain test-domain domain register --retention 2d

# get Async Queue config of the domain (should be empty)
go run cmd/tools/cli/main.go admin aq get \
  --domain test-domain

# update Async Queue config of the domain
go run cmd/tools/cli/main.go admin aq update \
  --domain test-domain \
  --json "{\"PredefinedQueueName\":\"queue1\"}"

# get Async Queue config of the domain (read what you write)
go run cmd/tools/cli/main.go admin aq get \
  --domain test-domain

Also tested other domain APIs such as list/describe.

@taylanisikdemir taylanisikdemir changed the title Upgrade domain_config type in cassandra schema to add async wf config [WIP] Upgrade domain_config type in cassandra schema to add async wf config Jan 26, 2024
@taylanisikdemir taylanisikdemir marked this pull request as ready for review January 26, 2024 19:44
@taylanisikdemir taylanisikdemir force-pushed the taylan/async_queue_config_db_schema branch from a6cf522 to 5bc614c Compare January 26, 2024 22:13
@taylanisikdemir taylanisikdemir changed the title [WIP] Upgrade domain_config type in cassandra schema to add async wf config Upgrade domain_config type in cassandra schema to add async wf config Jan 26, 2024
@taylanisikdemir taylanisikdemir changed the title Upgrade domain_config type in cassandra schema to add async wf config [WIP] Upgrade domain_config type in cassandra schema to add async wf config Jan 26, 2024
@taylanisikdemir taylanisikdemir force-pushed the taylan/async_queue_config_db_schema branch from 1103f8a to d3f7a9a Compare January 27, 2024 01:06
@taylanisikdemir taylanisikdemir force-pushed the taylan/async_queue_config_db_schema branch from cc8d8e0 to 73e3ea2 Compare February 5, 2024 16:44
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018d7a9a-72c6-4693-aec4-b4adbca15d8e

  • -8 of 37 (78.38%) changed or added relevant lines in 6 files are covered.
  • 140 unchanged lines in 22 files lost coverage.
  • Overall coverage decreased (-0.06%) to 62.646%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/nosql/nosqlplugin/cassandra/domain.go 21 25 84.0%
common/persistence/persistence-tests/metadataPersistenceV2Test.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
client/history/client.go 2 38.1%
common/membership/hashring.go 2 84.05%
common/persistence/executionManager.go 2 78.94%
common/persistence/sql/common.go 2 72.73%
common/persistence/sql/sqlplugin/postgres/db.go 2 85.0%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
service/history/handler.go 2 49.91%
service/history/task/transfer_standby_task_executor.go 2 86.6%
service/matching/db.go 2 73.23%
common/log/tag/tags.go 3 51.03%
Totals Coverage Status
Change from base Build 018d78de-2000-4f92-aa28-0059df445f10: -0.06%
Covered Lines: 92092
Relevant Lines: 147003

💛 - Coveralls

@taylanisikdemir taylanisikdemir changed the title [WIP] Upgrade domain_config type in cassandra schema to add async wf config Upgrade domain_config type in cassandra schema to add async wf config Feb 5, 2024
@taylanisikdemir taylanisikdemir merged commit 5175867 into cadence-workflow:master Feb 5, 2024
16 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/async_queue_config_db_schema branch February 5, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants