Add debug logs in PinotTripleVisibilityManager for response comparator testing #5631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenxia
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
|
This method can be moved into chooseVisibilityManagerForRead() so we don't need to do it twice. If it has override, we choose based on the override value, if not, use the original logic. |
|
The title needs to be updated, we need it for release |
bowenxia
changed the title
neil-xie
reviewed
Jan 26, 2024
neil-xie
reviewed
Jan 26, 2024
| if override := ctx.Value(ContextKey); override == Primary { | ||
| manager = v.esVisibilityManager | ||
| v.logger.Debug("primary was chosen") |
There was a problem hiding this comment.
let's change the message here to make it more reasonable to others, like primary visibility manager elasticsearch was chosen for read
neil-xie
approved these changes
Jan 26, 2024
| return manager.CountWorkflowExecutions(ctx, request) | ||
| } | ||
| v.logger.Debug("Pinot Migration log: ContextKey was empty.") | ||
| // temporary code: ends here <-- |
There was a problem hiding this comment.
probably better to just link to a task ID or a todo
There was a problem hiding this comment.
Created a Jira ticket to record this.
bowenxia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added debugging logs to PinotTripleVisibilityManager, for testing pinot response comparator
Why?
Without the logs, we can't know which database Cadence chooses.
How did you test it?
Potential risks
Release notes
Documentation Changes