Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async workflow request consumer for Start/SignalWithStart support #5658

Conversation

taylanisikdemir
Copy link
Member

@taylanisikdemir taylanisikdemir commented Feb 13, 2024

What changed?
Implemented Async workflow request consumer component which will consume requests from queue and call corresponding frontend API (sync version of the request). It currently support following async request types:

How did you test it?
Added unit tests. Integration and bench tests are coming soon.

@taylanisikdemir taylanisikdemir changed the title Async workflow request consumer Add async workflow request consumer for Start/SignalWithStart support Feb 13, 2024
@coveralls
Copy link

coveralls commented Feb 13, 2024

Pull Request Test Coverage Report for Build 018da5de-9ee4-4295-b66c-71e4a6090b3c

Details

  • -22 of 217 (89.86%) changed or added relevant lines in 7 files are covered.
  • 28 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.06%) to 62.784%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/worker/service.go 0 1 0.0%
common/log/tag/tags.go 0 3 0.0%
common/metrics/tags.go 0 3 0.0%
common/asyncworkflow/queue/kafka/queue.go 17 21 80.95%
common/asyncworkflow/queue/consumer/default_consumer.go 159 170 93.53%
Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
common/persistence/sql/sqlplugin/postgres/db.go 2 85.0%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
common/task/fifo_task_scheduler.go 2 87.63%
service/history/task/transfer_active_task_executor.go 2 72.31%
service/history/task/transfer_standby_task_executor.go 2 87.01%
common/asyncworkflow/queue/kafka/queue.go 3 84.31%
service/matching/taskListManager.go 3 80.71%
service/frontend/wrappers/metered/metered.go 4 65.5%
service/history/execution/mutable_state_task_refresher.go 7 71.2%
Totals Coverage Status
Change from base Build 018da536-b82b-454e-a15a-48f6f51419d7: 0.06%
Covered Lines: 92609
Relevant Lines: 147503

💛 - Coveralls

@taylanisikdemir taylanisikdemir merged commit eea917e into cadence-workflow:master Feb 14, 2024
14 of 16 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/async_wf_consumer branch February 14, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants