Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for membership resolver #5669

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

Shaddoll
Copy link
Member

What changed?
Improve error message for membership resolver

Why?
Improve debuggability

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018db343-cbf9-4478-a21a-d94dfba6f337

Details

  • -1 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 27 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.03%) to 62.747%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/membership/resolver.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_active_task_executor.go 2 72.38%
service/matching/matcher.go 2 90.72%
service/matching/taskListManager.go 2 80.46%
service/history/task/fetcher.go 3 86.6%
service/history/execution/mutable_state_task_refresher.go 7 62.03%
common/persistence/sql/workflowStateMaps.go 11 85.56%
Totals Coverage Status
Change from base Build 018daf40-3e91-4ef9-9d9a-c2dcb88ec597: 0.03%
Covered Lines: 92628
Relevant Lines: 147622

💛 - Coveralls

@Shaddoll Shaddoll merged commit 20ffcf4 into cadence-workflow:master Feb 16, 2024
15 of 16 checks passed
@Shaddoll Shaddoll deleted the hashring branch February 16, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants