Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more scenarios to createworkflowexecution test- Part1 #5690

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

agautam478
Copy link
Contributor

What changed?
Added 3 more test case scenarios to the CreateworkflowExecution test in order to cover all possible paths.

I will be adding more cases in the upcoming PR and will cover the other methods like GetworkflowExecution too.

Why?
to increase the code coverage.

How did you test it?
unit testing

Potential risks
NA

Release notes

Documentation Changes

@agautam478 agautam478 enabled auto-merge (squash) February 23, 2024 22:50
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018dd761-2bfd-408b-817b-41d6b48312ed

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 52 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.04%) to 62.911%

Files with Coverage Reduction New Missed Lines %
tools/cli/admin_db_decode_thrift.go 1 71.43%
common/task/fifo_task_scheduler.go 2 85.57%
service/history/execution/mutable_state_util.go 2 37.63%
service/history/task/timer_task_executor_base.go 2 78.38%
service/history/task/transfer_active_task_executor.go 2 72.38%
service/history/task/transfer_standby_task_executor.go 2 86.6%
service/matching/matcher.go 2 90.72%
service/matching/taskListManager.go 2 79.7%
service/history/task/fetcher.go 3 85.57%
service/history/execution/mutable_state_task_refresher.go 14 64.56%
Totals Coverage Status
Change from base Build 018dd44c-0cc4-4ccf-b1d0-54d7e8ea168e: 0.04%
Covered Lines: 92968
Relevant Lines: 147777

💛 - Coveralls

@agautam478 agautam478 merged commit c5863eb into cadence-workflow:master Feb 23, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants