Introduce new dynamic config for enabling wfID based ratelimiting #5703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobht
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Pull Request Test Coverage Report for Build 018e086b-5cca-4017-bcbb-a9fb44520178Details
💛 - Coveralls |
3vilhamster
approved these changes
Mar 4, 2024
ketsiambaku
pushed a commit
to ketsiambaku/cadence
that referenced
this pull request
Mar 6, 2024
…dence-workflow#5703) What changed? Introduced dynamic configs controlling if we are actually doing the wfID based rate limiting or just running in shadow mode Why? We can now see the effects of enabling the rate limiting and then immediately enable it without requiring another rollout. How did you test it? Potential risks Release notes Documentation Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Introduced dynamic configs controlling if we are actually doing the wfID based rate limiting or just running in shadow mode
Why?
We can now see the effects of enabling the rate limiting and then immediately enable it without requiring another rollout.
How did you test it?
Potential risks
Release notes
Documentation Changes