Implemented ratelimiting for external calls pr wfid (guarded by feature flag) #5704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobht
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Pull Request Test Coverage Report for Build 018e0d6d-0d8a-4c57-b8fc-d377a2e04eb7Details
💛 - Coveralls |
jakobht
changed the title
taylanisikdemir
approved these changes
Mar 4, 2024
jakobht
force-pushed
the
dynamicConfigRatelimit
branch
from
15a2798
to
d403290
Compare
ketsiambaku
pushed a commit
to ketsiambaku/cadence
that referenced
this pull request
Mar 6, 2024
…re flag) (cadence-workflow#5704) What changed? Implemented the actual rate limiting on the pr workflowID project Why? We can now roll it out and test it without needed to wait for rollouts How did you test it? Tested locally and with unit tests Potential risks Should be very low as it is guarded by a feature flag Release notes Documentation Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Implemented the actual rate limiting on the pr workflowID project
Why?
We can now roll it out and test it without needed to wait for rollouts
How did you test it?
Tested locally and with unit tests
Potential risks
Should be very low as it is guarded by a feature flag
Release notes
Documentation Changes