Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate a metadata file artifact in unit test buildkite job #5708

Conversation

taylanisikdemir
Copy link
Member

@taylanisikdemir taylanisikdemir commented Mar 4, 2024

What changed?
unit test job in buildkite pipelines will generate a new file as an artifact.

Why?
This is needed to integrate with SonarQube.

How did you test it?
Run ./scripts/buildkite/gen_coverage_metadata.sh .build/coverage/metadata.txt and check the content of metadata.txt.

commit-sha: 089095d18943cfc58bde19a1436876d97ec5559f
timestamp: 2024-03-04T19:35:21Z

Also checked the buildkite job that runs as part of the PR:
Screenshot 2024-03-04 at 12 19 44 PM

@coveralls
Copy link

coveralls commented Mar 4, 2024

Pull Request Test Coverage Report for Build 018e0b41-63d7-4de9-ba4d-75334ec09400

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 81 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.001%) to 62.924%

Files with Coverage Reduction New Missed Lines %
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/task/parallel_task_processor.go 2 93.06%
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
service/matching/taskListManager.go 2 79.7%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 61.45%
common/persistence/statsComputer.go 3 94.64%
common/task/fifo_task_scheduler.go 7 82.47%
common/persistence/sql/workflowStateMaps.go 11 83.84%
common/persistence/nosql/nosqlplugin/cassandra/workflow_parsing_utils.go 20 79.13%
service/history/execution/mutable_state_task_refresher.go 29 57.59%
Totals Coverage Status
Change from base Build 018e0b2e-f9ef-4696-ae22-4d312de4faa2: -0.001%
Covered Lines: 93010
Relevant Lines: 147813

💛 - Coveralls

@taylanisikdemir taylanisikdemir enabled auto-merge (squash) March 4, 2024 20:57
@taylanisikdemir taylanisikdemir merged commit aac1eb3 into cadence-workflow:master Mar 4, 2024
17 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/unit_test_artifact branch March 4, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants