Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional unit tests for functions in constants.go #5713

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

timl3136
Copy link
Member

@timl3136 timl3136 commented Mar 5, 2024

What changed?
Add unit tests for functions in constants.go

Why?
improve coverage

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Mar 5, 2024

Pull Request Test Coverage Report for Build 018e0fa8-60f0-48ba-b947-31f6cd133c5f

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 86 unchanged lines in 19 files lost coverage.
  • Overall coverage increased (+0.02%) to 63.131%

Files with Coverage Reduction New Missed Lines %
service/matching/taskGC.go 1 97.37%
common/membership/hashring.go 2 82.23%
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/persistence/sql/sqlplugin/mysql/db.go 2 83.33%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/task/fifo_task_scheduler.go 2 87.63%
common/task/weighted_round_robin_task_scheduler.go 2 88.06%
service/history/execution/mutable_state_builder.go 2 68.74%
service/history/task/fetcher.go 2 85.05%
service/history/task/timer_task_executor_base.go 2 78.38%
Totals Coverage Status
Change from base Build 018e0f91-436c-45b1-853d-c77bc9d2af65: 0.02%
Covered Lines: 92595
Relevant Lines: 146671

💛 - Coveralls

@timl3136 timl3136 enabled auto-merge (squash) March 5, 2024 17:28
@timl3136 timl3136 merged commit a8c257f into cadence-workflow:master Mar 5, 2024
17 checks passed
ketsiambaku pushed a commit to ketsiambaku/cadence that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants