Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for elasticsearch v6 client #5716

Merged
merged 7 commits into from
Mar 5, 2024

Conversation

neil-xie
Copy link
Member

@neil-xie neil-xie commented Mar 5, 2024

What changed?
Add unit test for NewV6Client, CreateIndex, PutMapping and Count

Why?
Improve test coverage

How did you test it?
Unit test

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Mar 5, 2024

Pull Request Test Coverage Report for Build 018e1071-f41c-4de3-a965-1763d1ef5be4

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 49 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.05%) to 63.2%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
service/history/queue/timer_queue_processor_base.go 1 77.62%
service/matching/taskGC.go 1 97.37%
common/membership/hashring.go 2 82.23%
common/persistence/historyManager.go 2 66.67%
common/persistence/sql/sqlplugin/postgres/db.go 2 80.0%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
service/history/execution/mutable_state_builder.go 2 68.74%
service/history/task/transfer_active_task_executor.go 2 72.38%
service/matching/matcher.go 2 91.41%
Totals Coverage Status
Change from base Build 018e1070-ebcc-4449-b3da-fbe3488a2176: 0.05%
Covered Lines: 92693
Relevant Lines: 146665

💛 - Coveralls

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Merging #5716 (ef45eab) into master (bed1969) will decrease coverage by 0.08%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head ef45eab differs from pull request most recent head 035a4b4. Consider uploading reports for the commit 035a4b4 to get more accurate results

Additional details and impacted files

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88cfab0...035a4b4. Read the comment docs.

@neil-xie neil-xie merged commit e1f4252 into cadence-workflow:master Mar 5, 2024
18 checks passed
@neil-xie neil-xie deleted the CDNC_6987 branch March 5, 2024 22:36
ketsiambaku pushed a commit to ketsiambaku/cadence that referenced this pull request Mar 6, 2024
* Add es v6 client test for new es v6 client method and index operations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants