Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more unit tests for persistence task types in DataManagerInterfaces #5726

Merged

Conversation

timl3136
Copy link
Member

@timl3136 timl3136 commented Mar 5, 2024

What changed?
Add unit tests for the common task types and some other task types

Why?
Improve unit test coverage and stability of the platform

How did you test it?
Unit test

Potential risks

Release notes

Documentation Changes

@timl3136 timl3136 enabled auto-merge (squash) March 5, 2024 22:27
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Merging #5726 (e25a286) into master (cb39e82) will increase coverage by 0.20%.
The diff coverage is n/a.

Additional details and impacted files

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb39e82...e25a286. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 5, 2024

Pull Request Test Coverage Report for Build 018e14b0-d10b-461e-9b50-5ca53bae8deb

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 81 unchanged lines in 17 files lost coverage.
  • Overall coverage increased (+0.1%) to 63.437%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
common/membership/hashring.go 2 82.23%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/task/fifo_task_scheduler.go 2 87.63%
common/task/parallel_task_processor.go 2 93.06%
service/frontend/api/handler.go 2 62.05%
service/history/execution/mutable_state_util.go 2 78.48%
service/history/task/transfer_active_task_executor.go 2 72.38%
service/matching/db.go 2 73.23%
Totals Coverage Status
Change from base Build 018e14af-234b-487e-b5a6-c5632b10bbb6: 0.1%
Covered Lines: 93052
Relevant Lines: 146684

💛 - Coveralls

@timl3136 timl3136 merged commit 45d755e into cadence-workflow:master Mar 6, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants