Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for pinot folder with coverage to 93.4% #5761

Merged
merged 6 commits into from
Mar 8, 2024

Conversation

bowenxia
Copy link
Contributor

@bowenxia bowenxia commented Mar 8, 2024

What changed?
Added unit test for common/pinot folder

Why?
to reach a better code coverage

How did you test it?
unit test

Potential risks

Release notes

Documentation Changes

common/pinot/pinotClient_test.go Outdated Show resolved Hide resolved
common/pinot/pinotClient_test.go Show resolved Hide resolved
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Merging #5761 (eeeb19d) into master (8c1eba8) will increase coverage by 0.06%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head eeeb19d differs from pull request most recent head 6f9d1df. Consider uploading reports for the commit 6f9d1df to get more accurate results

Additional details and impacted files
Files Coverage Δ
common/pinot/pinot_client.go 96.61% <ø> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 832700b...6f9d1df. Read the comment docs.

@bowenxia bowenxia enabled auto-merge (squash) March 8, 2024 01:00
@bowenxia bowenxia merged commit ee74964 into master Mar 8, 2024
19 checks passed
@bowenxia bowenxia deleted the xbowen_pinot_folder_test01 branch March 8, 2024 01:35
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018e1ba1-da71-48fe-ba1c-94a779d8e438

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 98 unchanged lines in 15 files lost coverage.
  • Overall coverage increased (+0.04%) to 63.444%

Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.62%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/matching/db.go 2 73.23%
service/history/task/transfer_active_task_executor.go 2 72.51%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/persistence/sql/common.go 2 46.75%
common/persistence/sql/sql_task_store.go 2 54.32%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/history/task/fetcher.go 3 85.57%
common/log/tag/tags.go 3 50.18%
Totals Coverage Status
Change from base Build 018e1ba1-54d2-4d9d-9c86-3b41b0eb9f6f: 0.04%
Covered Lines: 93007
Relevant Lines: 146598

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants