adding mutable state builder tests - adding continue-as-new events #5768
Conversation
…b.com:davidporter-id-au/cadence into refactor/adding-mutable-state-builder-tests-i
davidporter-id-au
requested review from
Shaddoll,
neil-xie,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
davidporter-id-au
changed the title
Codecov Report
Additional details and impacted files
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Pull Request Test Coverage Report for Build 018e2a7e-1aec-4241-9bfd-665ab32ccb6dDetails
💛 - Coveralls |
| td.expectedReturnedState.RunID = "a run id" | ||
| resultExecutionInfo.RunID = "a run id" | ||
| td.expectedReturnedState.CreateRequestID = "a request id" | ||
| resultExecutionInfo.CreateRequestID = "a request id" | ||
| for _, historyEvent := range returnedBuilder.GetHistoryBuilder().history { | ||
| if historyEvent.WorkflowExecutionStartedEventAttributes != nil { | ||
| historyEvent.WorkflowExecutionStartedEventAttributes.OriginalExecutionRunID = "a run id" | ||
| } | ||
| } |
There was a problem hiding this comment.
another option for such fields that are not predictable to validate in tests is to use cmpopts.IgnoreFields and cmp.Diff instead of assert.Equal. Example https://github.com/uber/cadence/blob/a614c4c1fd1cf94b3722193cec919985304c9acb/common/types/mapper/thrift/shared_test.go#L1407
There was a problem hiding this comment.
Fair point, I didn't know it had that param.
I would like to refactor the code so that this param can be passed in (I hate when functions use time.Now, uuid generation or math.rand in the middle of their logic) but that can wait.
service/history/execution/mutable_state_builder_add_continue_as_new_event_test.go
Show resolved
Hide resolved
davidporter-id-au
merged commit 4d513c0
into
cadence-workflow:master
What changed?
Adds some unit tests to the mutable state builder around the Continue-as-new event.
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes