Refactor/adding mutable state builder tests iv #5769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b.com:davidporter-id-au/cadence into refactor/adding-mutable-state-builder-tests-i
Codecov Report
Additional details and impacted files
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
davidporter-id-au
requested review from
Shaddoll,
neil-xie,
Groxx,
shijiesheng,
agautam478 and
jakobht
as code owners
davidporter-id-au
requested review from
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Pull Request Test Coverage Report for Build 018e2c5b-524c-4ca0-bf7a-1119f4e3b280Details
💛 - Coveralls |
taylanisikdemir
approved these changes
Mar 11, 2024
| tags = append(tags, tag.WorkflowRunID(e.executionInfo.RunID)) | ||
| tags = append(tags, tag.WorkflowDomainID(e.executionInfo.DomainID)) | ||
| e.logger.Info(msg, tags...) | ||
| if e != nil && e.executionInfo != nil { |
There was a problem hiding this comment.
do we need these nil checks? If so let's check for nilness and terminate early.
if e == nil || e.executionInfo == nil {
return
}
// log with tags
There was a problem hiding this comment.
ops approved with comment but didn't notice auto merge is enabled :)
There was a problem hiding this comment.
ah, sorry about that, let me address in a follow up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
assignEventIDToBufferedEventswho's function it is is to increment the various counters and ensure that all buffered decision tasks have assigned IDs.Why?
How did you test it?
Potential risks
Release notes
Documentation Changes