Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update duplicate request error to include request type #5910

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

Shaddoll
Copy link
Member

What changed?
Update duplicate request error to include request type

Why?
To improve debugability

How did you test it?
unit tests and persistence tests

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Apr 15, 2024

Pull Request Test Coverage Report for Build 018ee42f-10b8-4e79-8f10-56c8f94d663e

Details

  • 26 of 34 (76.47%) changed or added relevant lines in 4 files are covered.
  • 72 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.003%) to 67.373%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/nosql/nosqlplugin/cassandra/workflow_utils.go 22 26 84.62%
common/persistence/persistence-tests/executionManagerTest.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
common/persistence/execution_manager.go 2 83.74%
service/frontend/api/handler.go 2 61.92%
common/util.go 2 91.78%
common/membership/hashring.go 2 84.69%
common/persistence/statsComputer.go 2 97.14%
service/history/queue/timer_queue_processor_base.go 3 77.82%
common/archiver/filestore/historyArchiver.go 4 80.95%
common/task/fifo_task_scheduler.go 4 83.51%
service/history/task/transfer_standby_task_executor.go 6 87.01%
service/history/execution/mutable_state_task_refresher.go 7 67.09%
Totals Coverage Status
Change from base Build 018ed3e8-7f9e-4b87-abf1-8d3b8bfd9075: 0.003%
Covered Lines: 98500
Relevant Lines: 146202

💛 - Coveralls

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Merging #5910 (c40a698) into master (ba39678) will decrease coverage by 0.01%.
The diff coverage is 85.71%.

Additional details and impacted files
Files Coverage Δ
common/persistence/errors.go 0.00% <ø> (ø)
common/persistence/nosql/nosql_execution_store.go 73.58% <100.00%> (+0.05%) ⬆️
...on/persistence/nosql/nosql_execution_store_util.go 84.89% <100.00%> (+0.60%) ⬆️
...ence/nosql/nosqlplugin/cassandra/workflow_utils.go 92.91% <83.33%> (-0.23%) ⬇️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba39678...c40a698. Read the comment docs.

Copy link
Member

@taylanisikdemir taylanisikdemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As codecov highlights there are some uncovered branches in workflow_utils. Let's try to address them (in this PR or a follow up) because those are critical to the behavior of upper layers

@Shaddoll Shaddoll merged commit 6d8466c into cadence-workflow:master Apr 16, 2024
20 checks passed
@Shaddoll Shaddoll deleted the duplicate-request-err branch April 16, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants