Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for persistence/workflow_execution_info.go #5918

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

natemort
Copy link
Member

Additionally rename file to match snake_case standard.

What changed?
Add tests for workflow_execution_info.go

Why?
Improving test coverage

How did you test it?
Unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Merging #5918 (6d3613c) into master (1c7d522) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 6d3613c differs from pull request most recent head b2c9157. Consider uploading reports for the commit b2c9157 to get more accurate results

Additional details and impacted files
Files Coverage Δ
common/persistence/workflow_execution_info.go 97.95% <ø> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c7d522...b2c9157. Read the comment docs.

@natemort natemort enabled auto-merge (squash) April 18, 2024 00:19
@natemort natemort disabled auto-merge April 18, 2024 00:19
@natemort natemort enabled auto-merge (squash) April 18, 2024 00:19
@coveralls
Copy link

coveralls commented Apr 18, 2024

Pull Request Test Coverage Report for Build 018eeed7-8405-4957-8a21-53b38c2f3226

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 63 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.03%) to 67.53%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 88.06%
common/task/fifo_task_scheduler.go 2 85.57%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/matching/taskListManager.go 2 80.2%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
service/history/task/transfer_standby_task_executor.go 4 86.19%
common/persistence/pinot_visibility_triple_manager.go 9 97.65%
service/history/execution/mutable_state_task_refresher.go 17 61.71%
service/history/task/task_util.go 24 69.43%
Totals Coverage Status
Change from base Build 018eee92-de3e-4218-a5af-7f3a6bbaef48: 0.03%
Covered Lines: 98848
Relevant Lines: 146376

💛 - Coveralls

@natemort natemort merged commit 7cd0f80 into cadence-workflow:master Apr 18, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants