Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for ForkHistoryBranch #5922

Conversation

jakobht
Copy link
Member

@jakobht jakobht commented Apr 19, 2024

What changed?
Tests for fork history branch

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Apr 19, 2024

Pull Request Test Coverage Report for Build 018f1618-17b6-4049-abd3-e4a402a18dc8

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 24 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.02%) to 67.746%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
common/persistence/sql/sqlplugin/postgres/db.go 2 80.0%
common/task/fifo_task_scheduler.go 2 87.63%
service/history/queue/timer_queue_processor_base.go 3 77.82%
service/history/execution/mutable_state_task_refresher.go 14 64.56%
Totals Coverage Status
Change from base Build 018f127b-cd0f-43c3-b47a-35b58b7623db: 0.02%
Covered Lines: 99370
Relevant Lines: 146680

💛 - Coveralls

Copy link
Member

@davidporter-id-au davidporter-id-au left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though I'm not quite confident enough with history to feel super firm being the only stamp. @Shaddoll any thoughts?

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.59%. Comparing base (0b41007) to head (e84579f).
Report is 1 commits behind head on master.

❗ Current head e84579f differs from pull request most recent head 84da703. Consider uploading reports for the commit 84da703 to get more accurate results

Additional details and impacted files

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dd0045...84da703. Read the comment docs.

@jakobht jakobht enabled auto-merge (squash) April 25, 2024 18:15
@jakobht jakobht merged commit 9524eca into cadence-workflow:master Apr 25, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants