Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for DeleteHistoryBranch #5943

Conversation

jakobht
Copy link
Member

@jakobht jakobht commented Apr 26, 2024

What changed?
Added tests for DeleteHistoryBranch

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Apr 26, 2024

Pull Request Test Coverage Report for Build 018f1ee9-712b-497b-83a3-ede42ed2ab94

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 48 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.005%) to 67.778%

Files with Coverage Reduction New Missed Lines %
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
common/task/fifo_task_scheduler.go 2 83.51%
service/history/execution/mutable_state_builder.go 2 71.09%
service/history/queue/transfer_queue_processor.go 2 57.17%
service/matching/matcher.go 2 90.72%
service/history/task/transfer_standby_task_executor.go 9 86.63%
common/persistence/sql/sqlplugin/postgres/db.go 9 65.0%
service/history/task/task_util.go 20 70.57%
Totals Coverage Status
Change from base Build 018f1c52-079d-4525-90c9-6009c700fa94: -0.005%
Covered Lines: 99489
Relevant Lines: 146786

💛 - Coveralls

@jakobht jakobht enabled auto-merge (squash) April 26, 2024 14:16
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.75%. Comparing base (cf2f77a) to head (607b6d9).

Additional details and impacted files

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf2f77a...607b6d9. Read the comment docs.

@jakobht jakobht merged commit 969a6c6 into cadence-workflow:master Apr 27, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants