Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong comment on enableAsyncWorkflowConsumption dynamic config #5964

Merged

Conversation

taylanisikdemir
Copy link
Member

What changed?
Key name should have been worker.enableAsyncWorkflowConsumption but was system.enableAsyncWorkflowConsumption.

@taylanisikdemir taylanisikdemir enabled auto-merge (squash) May 2, 2024 16:26
@taylanisikdemir taylanisikdemir merged commit 959c5bf into cadence-workflow:master May 2, 2024
17 of 18 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f3a1f-73b3-43a5-bfd7-bf52dcb292f1

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 59 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.02%) to 68.083%

Files with Coverage Reduction New Missed Lines %
service/matching/taskReader.go 2 83.55%
common/task/parallel_task_processor.go 2 93.06%
common/util.go 2 91.78%
service/matching/matcher.go 2 91.41%
service/history/execution/mutable_state_util.go 2 78.52%
common/persistence/historyManager.go 2 66.67%
common/task/weighted_round_robin_task_scheduler.go 3 87.06%
common/persistence/statsComputer.go 3 96.07%
service/history/task/fetcher.go 4 85.05%
service/history/execution/mutable_state_task_refresher.go 17 56.65%
Totals Coverage Status
Change from base Build 018f3600-6fcf-45e7-b48b-9de2fc42208d: -0.02%
Covered Lines: 99982
Relevant Lines: 146853

💛 - Coveralls

@taylanisikdemir taylanisikdemir deleted the taylan/minor_fix branch May 2, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants