Enforcing go vet -copylocks and fixing current violations #5967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Groxx
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…ule" to check like this so it is skipped
|
Currently blocked on #5967 due to test flakiness. |
agautam478
pushed a commit
to agautam478/cadence
that referenced
this pull request
May 8, 2024
…rkflow#5967) Thankfully this all appears to be test-related and not any real risks, but I realized while writing some other code that `go test` doesn't check this. I'm really not sure what scenarios it might be wrong in, but it catches loads of incorrect concurrent code in my experience. So now it's required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thankfully this all appears to be test-related and not any real risks,
but I realized while writing some other code that
go testdoesn't check this.I'm really not sure what scenarios it might be wrong in, but it catches loads
of incorrect concurrent code in my experience. So now it's required.