Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tests for starting, stopping and purging daemon for replicationQueue #5973

Merged
merged 16 commits into from
Jun 5, 2024
Merged

Added tests for starting, stopping and purging daemon for replicationQueue #5973

merged 16 commits into from
Jun 5, 2024

Conversation

abhishekj720
Copy link
Contributor

What changed?
Added tests for replicationQueue present in common domain

Why?
As part of test coverage week

How did you test it?
Unit tests

Potential risks
No risks. Added to avoid risks

Release notes

Documentation Changes

@codecov Codecov
Copy link

codecov bot commented May 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.04%. Comparing base (17a7ba7) to head (b9d24b3).
Report is 112 commits behind head on master.

Additional details and impacted files

see 141 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17a7ba7...b9d24b3. Read the comment docs.

taylanisikdemir and others added 9 commits May 7, 2024 14:23
@taylanisikdemir @abhishekj720
Replace wurstmeister kafka/zookeeper images with bitnami kafka image (c…
d0e586c 
…adence-workflow#5975)
@taylanisikdemir @abhishekj720
Split historyEngine.go into small files (cadence-workflow#5972)
0efab43
@timl3136 @abhishekj720
Added unit tests for service/history/handler (cadence-workflow#5970)
dedc023 
* Added unit tests for history handler
@Shaddoll @abhishekj720
Add unit tests for mutable state task refresher (cadence-workflow#5971)
b28766e
@taylanisikdemir @abhishekj720
Revert codecov patch threshold to 85% (cadence-workflow#5982)
d45186d
@ibarrajo @abhishekj720
Api handler test respond activity task failed alternate (cadence-work…
c21a71a 
…flow#5980)

* TestRespondActivityTaskFailed_Success implementation

* Alternate test for TerstRespondActivityTaskFailed

* code lint
@natemort @abhishekj720
Move shardscanner workflow tests to the shardscanner package (cadence…
7eed1c1 
…-workflow#5981)

This ensures they get included in the code coverage metrics.
@abhishekj720
Change after review
1e8c374
@abhishekj720
Merge branch 'uber:master' into crq1
6374678
@coveralls
Copy link

coveralls commented May 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 018fe99e-3846-4774-9def-a910916f1b04

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 56 unchanged lines in 16 files lost coverage.
  • Overall coverage decreased (-0.004%) to 68.408%
Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 88.06%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
service/history/handler/handler.go 2 60.71%
service/matching/db.go 2 73.23%
common/util.go 2 91.78%
service/history/execution/mutable_state_util.go 2 78.52%
common/membership/hashring.go 2 84.69%
common/log/tag/tags.go 3 50.46%
common/task/fifo_task_scheduler.go 3 84.54%
service/history/queue/timer_queue_processor_base.go 3 77.87%
Totals Coverage Status
Change from base Build 018f54e5-7508-40f1-ae99-a0884c40b0fa: -0.004%
Covered Lines: 100478
Relevant Lines: 146880
💛 - Coveralls

@abhishekj720 abhishekj720 merged commit 4326afb into cadence-workflow:master Jun 5, 2024
20 checks passed
@abhishekj720 abhishekj720 deleted the crq1 branch June 5, 2024 18:53
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
@abhishekj720 @timl3136
Added tests for starting, stopping and purging daemon for replication…
a9575ca 
…Queue (cadence-workflow#5973)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylanisikdemir taylanisikdemir taylanisikdemir left review comments

@Groxx Groxx Groxx left review comments

@agautam478 agautam478 agautam478 approved these changes

@Shaddoll Shaddoll Awaiting requested review from Shaddoll Shaddoll is a code owner

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@davidporter-id-au davidporter-id-au Awaiting requested review from davidporter-id-au davidporter-id-au is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@jakobht jakobht Awaiting requested review from jakobht jakobht is a code owner

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster 3vilhamster is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@abhishekj720 @coveralls @Groxx @taylanisikdemir @agautam478 @timl3136 @Shaddoll @ibarrajo @natemort