Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce flakiness on workflow-ID-specific ratelimit test #5986

Merged
merged 3 commits into from
May 8, 2024
Merged

Reduce flakiness on workflow-ID-specific ratelimit test #5986

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f338796
Reduce flakiness on workflow-ID-specific ratelimit test
Groxx May 8, 2024
45a9aee
raising to 4, seems stable enough that it might be sufficient
Groxx May 8, 2024
99782f7
more specific comment
Groxx May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions host/workflowidratelimit_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,21 +127,29 @@ func (s *WorkflowIDRateLimitIntegrationSuite) TestWorkflowIDSpecificRateLimits()
ctx, cancel := createContext()
defer cancel()

// The ratelimit is 5 per second, so we should be able to start 5 workflows without any error
// The ratelimit is 5 per second with a burst of 5, so we should be able to start 5 workflows without any error
for i := 0; i < 5; i++ {
_, err := s.engine.StartWorkflowExecution(ctx, request)
assert.NoError(s.T(), err)
}

// Now we should get a rate limit error
// Now we should get a rate limit error (with some fuzziness for time passing)
limited := 0
for i := 0; i < 5; i++ {
_, err := s.engine.StartWorkflowExecution(ctx, request)
var busyErr *types.ServiceBusyError
assert.ErrorAs(s.T(), err, &busyErr)
assert.Equal(s.T(), common.WorkflowIDRateLimitReason, busyErr.Reason)
if err != nil {
if assert.ErrorAs(s.T(), err, &busyErr) {
limited++
assert.Equal(s.T(), common.WorkflowIDRateLimitReason, busyErr.Reason)
}
}
}
// 5 fails occasionally, trying 4. If needed, reduce to 3 or find a way to
// make this test less sensitive to latency, as test-runner hosts vary a lot.
assert.GreaterOrEqual(s.T(), limited, 4, "should have encountered some rate-limit errors after the burst was exhausted")

// After 1 second we should be able to start another workflow
// After 1 second (200ms at a minimum) we should be able to start more workflows without being limited
time.Sleep(1 * time.Second)
_, err := s.engine.StartWorkflowExecution(ctx, request)
assert.NoError(s.T(), err)
Expand Down
Loading