Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling for history handler #6020

Merged
merged 1 commit into from
May 14, 2024

Conversation

Shaddoll
Copy link
Member

What changed?

  • convert perisistence.TimeoutError to InternalServiceError for history handler
  • Improve error metric for history handler

Why?
Some transfer tasks are not retried and dropped when persistence.TimeoutError is returned. And the error was originally not converted to a retryable error. The PR is to fix the issue.

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented May 13, 2024

Pull Request Test Coverage Report for Build 018f73ed-3234-426c-82b1-ed1bd8cda0b7

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • 39 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.002%) to 69.172%

Files with Coverage Reduction New Missed Lines %
tools/cli/admin_db_decode_thrift.go 1 71.79%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/matching/tasklist/db.go 2 73.23%
service/frontend/api/handler.go 2 62.32%
common/persistence/historyManager.go 2 66.67%
common/log/tag/tags.go 3 50.46%
common/archiver/filestore/historyArchiver.go 4 80.95%
common/persistence/nosql/nosql_task_store.go 5 61.95%
service/matching/tasklist/task_reader.go 9 75.6%
service/frontend/wrappers/metered/metered.go 9 63.18%
Totals Coverage Status
Change from base Build 018f738f-70da-4942-afab-552bc50965d4: 0.002%
Covered Lines: 101838
Relevant Lines: 147224

💛 - Coveralls

@Shaddoll Shaddoll merged commit ad8d28e into cadence-workflow:master May 14, 2024
18 checks passed
@Shaddoll Shaddoll deleted the error branch May 14, 2024 19:06
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants