Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel-able reservations for ratelimiters #6030

Merged
merged 22 commits into from
May 28, 2024
Merged

Cancel-able reservations for ratelimiters #6030

Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
2929ec4
Mock-clock-capable ratelimiter wrapper
Groxx May 19, 2024
192beb9
added a compressed-replay test to make sure time can be advanced fast…
Groxx May 19, 2024
df27891
document a way to fix the multi-stage limiter, but do not implement it
Groxx May 19, 2024
ace5f34
more docs, describe a safer workaround but do not implement
Groxx May 19, 2024
f5dac1c
Pin ratelimiter time so reservations can be canceled asynchronously
Groxx May 20, 2024
3a09757
benchmarkstravaganza
Groxx May 21, 2024
81074de
Bugfix and detailed benchmark info
Groxx May 21, 2024
e2d892c
updated after fix
Groxx May 21, 2024
0dd64e9
fixed benchmark counting flaws, time-per-allow helps understand a lot
Groxx May 21, 2024
e6ca900
benched on linux box
Groxx May 21, 2024
bdf35ce
updated snapshots and analysis
Groxx May 21, 2024
1bb0d0c
more precise explanation for *rate.Limiter flaw, notes in code to pro…
Groxx May 21, 2024
500d43f
Restore more tokens when contended, and slight test setup improvement
Groxx May 22, 2024
6043308
simplified allowed-reservation slightly, gathering new perf
Groxx May 22, 2024
daa8449
updated benchmarks
Groxx May 22, 2024
944237e
major test refactor, moved benchmark to a new file, updated comments
Groxx May 24, 2024
9d890ec
100% coverage with "real" tests, on both real and fake time
Groxx May 24, 2024
f6ce8c1
reducing flakiness a bit
Groxx May 24, 2024
ac5a850
more noise, now stable across hundreds tho
Groxx May 24, 2024
26b021b
clean pr
Groxx May 24, 2024
fc3451b
Merge branch 'master' into ratelimiter-locked-limiter
Groxx May 28, 2024
fd398d7
small comment improvements, swap sync.Once for a simpler thing
Groxx May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading