Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for GetOrphanTasks #6036

Merged

Conversation

jakobht
Copy link
Member

@jakobht jakobht commented May 21, 2024

What changed?
Added tests

Why?
Increase code coverage

How did you test it?

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.00%. Comparing base (9363cfe) to head (73dbc94).
Report is 5 commits behind head on master.

Current head 73dbc94 differs from pull request most recent head 2fe5520

Please upload reports for the commit 2fe5520 to get more accurate results.

Additional details and impacted files

see 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9363cfe...2fe5520. Read the comment docs.

@3vilhamster
Copy link
Member

I don't think this test adds anything to our code base. Please, focus on the functionality that is actually used. This looks like a test purely for coverage :(

@jakobht jakobht force-pushed the no_sql_task_store_test_getOrphanTasks branch from 73dbc94 to 359cb46 Compare May 23, 2024 06:48
@jakobht jakobht requested a review from shijiesheng as a code owner May 23, 2024 06:48
@jakobht jakobht force-pushed the no_sql_task_store_test_getOrphanTasks branch from 359cb46 to 2fe5520 Compare May 23, 2024 06:49
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018fa436-b062-4053-8e48-158b3af95147

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 112 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.05%) to 69.211%

Files with Coverage Reduction New Missed Lines %
service/history/shard/context.go 1 69.08%
service/history/task/transfer_standby_task_executor.go 2 86.21%
service/matching/tasklist/task_list_manager.go 2 76.48%
common/task/fifo_task_scheduler.go 2 87.63%
service/history/execution/mutable_state_util.go 2 78.52%
service/history/execution/mutable_state_builder.go 9 77.86%
service/history/execution/mutable_state_builder_methods_timer.go 14 67.03%
common/persistence/execution_manager.go 22 83.74%
service/history/execution/mutable_state_builder_methods_activity.go 58 59.02%
Totals Coverage Status
Change from base Build 018fa25a-37ac-4e2f-9de0-0090786e76c2: -0.05%
Covered Lines: 101950
Relevant Lines: 147303

💛 - Coveralls

@jakobht jakobht merged commit fb4bfce into cadence-workflow:master May 23, 2024
18 checks passed
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants