Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RetryActivity to the corresponding file #6038

Merged
merged 1 commit into from
May 23, 2024

Conversation

Shaddoll
Copy link
Member

What changed?
Move RetryActivity to the corresponding file

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f9cfa-0192-46a5-a519-a550cb71d4f6

Details

  • 40 of 44 (90.91%) changed or added relevant lines in 1 file are covered.
  • 62 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.01%) to 69.218%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/history/execution/mutable_state_builder_methods_activity.go 40 44 90.91%
Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 88.06%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
service/matching/tasklist/task_list_manager.go 2 76.09%
service/matching/tasklist/matcher.go 2 89.35%
common/persistence/historyManager.go 2 66.67%
service/history/handler/handler.go 3 96.2%
common/persistence/statsComputer.go 3 96.79%
service/frontend/api/handler.go 4 62.26%
service/history/task/fetcher.go 4 86.08%
common/persistence/sql/sqlplugin/postgres/db.go 9 65.0%
Totals Coverage Status
Change from base Build 018f9c40-fe62-4cf4-8ea6-9954fa724ff7: -0.01%
Covered Lines: 101898
Relevant Lines: 147214

💛 - Coveralls

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 78.37838% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 67.05%. Comparing base (02c7efb) to head (5965830).
Report is 9 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
...on/mutable_state_builder_methods_child_workflow.go 1.72% <ø> (-8.68%) ⬇️
...xecution/mutable_state_builder_methods_activity.go 40.64% <78.37%> (+3.52%) ⬆️

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbe87aa...5965830. Read the comment docs.

@Shaddoll Shaddoll merged commit 919f416 into cadence-workflow:master May 23, 2024
20 checks passed
@Shaddoll Shaddoll deleted the execution branch May 23, 2024 16:49
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants