Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for GetTaskListSize #6039

Merged

Conversation

jakobht
Copy link
Member

@jakobht jakobht commented May 22, 2024

What changed?
Added unit tests for GetTaskListSize

Why?
Increase coverage

How did you test it?

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.08%. Comparing base (02c7efb) to head (49e84b2).
Report is 4 commits behind head on master.

Additional details and impacted files

see 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0b0576...49e84b2. Read the comment docs.

@jakobht jakobht force-pushed the no_sql_task_store_test_GetTaskListSize branch from 8df5eef to 49e84b2 Compare May 22, 2024 10:39
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f9fe2-a0a0-4975-a44f-6d351cad86bb

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 183 unchanged lines in 19 files lost coverage.
  • Overall coverage decreased (-0.03%) to 69.176%

Files with Coverage Reduction New Missed Lines %
common/persistence/nosql/nosql_visibility_store.go 1 48.78%
service/history/queue/timer_queue_processor_base.go 1 77.66%
common/task/parallel_task_processor.go 2 93.06%
common/dynamicconfig/constants.go 2 99.05%
service/history/task/transfer_active_task_executor.go 2 72.85%
common/membership/hashring.go 2 84.69%
service/matching/tasklist/matcher.go 2 89.35%
service/matching/tasklist/task_reader.go 2 75.07%
common/persistence/historyManager.go 2 66.67%
service/matching/tasklist/task_list_manager.go 3 75.89%
Totals Coverage Status
Change from base Build 018f9f5c-2963-46a5-8e77-e52888c66415: -0.03%
Covered Lines: 101831
Relevant Lines: 147206

💛 - Coveralls

@jakobht jakobht merged commit 9363cfe into cadence-workflow:master May 22, 2024
20 checks passed
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants