Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for mutable_state_builder_methods_timer.go #6040

Merged
merged 4 commits into from
May 22, 2024
Merged

Add tests for mutable_state_builder_methods_timer.go #6040

merged 4 commits into from
May 22, 2024

Conversation

sankari165
Copy link
Member

What changed?
tests for mutable_state_builder_methods_timer.go

Why?
improve unit test coverage

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

@codecov Codecov
Copy link

codecov bot commented May 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.16%. Comparing base (02c7efb) to head (4ab7951).
Report is 6 commits behind head on master.

Additional details and impacted files

see 19 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02c7efb...4ab7951. Read the comment docs.

ketsiambaku
ketsiambaku approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@ketsiambaku ketsiambaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018fa00b-1dc3-4c4e-9db0-aeac9d041987

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 194 unchanged lines in 17 files lost coverage.
  • Overall coverage increased (+0.03%) to 69.227%
Files with Coverage Reduction New Missed Lines %
common/persistence/nosql/nosql_visibility_store.go 1 48.78%
service/history/queue/timer_queue_processor_base.go 1 77.66%
common/dynamicconfig/constants.go 2 99.05%
service/matching/tasklist/task_reader.go 2 77.45%
common/persistence/historyManager.go 2 66.67%
service/history/handler/handler.go 3 96.2%
service/matching/tasklist/matcher.go 4 88.66%
service/frontend/wrappers/metered/metered.go 4 66.67%
service/history/config/config.go 6 83.23%
service/history/task/fetcher.go 6 85.05%
Totals Coverage Status
Change from base Build 018f9f5c-2963-46a5-8e77-e52888c66415: 0.03%
Covered Lines: 101906
Relevant Lines: 147206
💛 - Coveralls

@sankari165 sankari165 merged commit 566388f into cadence-workflow:master May 22, 2024
20 checks passed
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
@sankari165 @timl3136
Add tests for mutable_state_builder_methods_timer.go (cadence-workflo…
11587ac 
…w#6040)

* Add tests for mutable_state_builder_methods_activity.go

* Update mutable_state_builder_methods_activity_test.go

* Add tests for mutable_state_builder_methods_timer.go

* Update mutable_state_builder_methods_timer_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ketsiambaku ketsiambaku ketsiambaku approved these changes

@Shaddoll Shaddoll Awaiting requested review from Shaddoll Shaddoll is a code owner

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@davidporter-id-au davidporter-id-au Awaiting requested review from davidporter-id-au davidporter-id-au is a code owner

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@agautam478 agautam478 Awaiting requested review from agautam478

@jakobht jakobht Awaiting requested review from jakobht jakobht is a code owner

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster 3vilhamster is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@taylanisikdemir taylanisikdemir Awaiting requested review from taylanisikdemir taylanisikdemir is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sankari165 @coveralls @ketsiambaku