Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for GetTasks #6048

Merged

Conversation

jakobht
Copy link
Member

@jakobht jakobht commented May 23, 2024

What changed?
Added tests for GetTask

Why?
Code coverage

How did you test it?

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.61%. Comparing base (fb4bfce) to head (69d9361).
Report is 5 commits behind head on master.

Additional details and impacted files

see 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb4bfce...69d9361. Read the comment docs.

@jakobht jakobht force-pushed the no_sql_task_store_test_GetTasks branch 2 times, most recently from 21ee0ac to 8c79538 Compare May 24, 2024 07:43
@jakobht jakobht force-pushed the no_sql_task_store_test_GetTasks branch from 8c79538 to 69d9361 Compare May 24, 2024 08:09
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018fa9a6-4e99-4d16-b903-3b08dab94a4e

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 333 unchanged lines in 21 files lost coverage.
  • Overall coverage decreased (-0.2%) to 69.291%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/persistence/sql/sql_execution_store_util.go 2 84.82%
common/persistence/sql/common.go 2 89.61%
common/util.go 2 91.78%
common/persistence/statsComputer.go 2 97.14%
service/matching/tasklist/matcher.go 2 89.35%
service/matching/tasklist/task_reader.go 2 77.45%
service/history/queue/timer_queue_processor_base.go 3 77.87%
service/history/task/transfer_standby_task_executor.go 4 86.21%
common/archiver/filestore/historyArchiver.go 4 80.95%
Totals Coverage Status
Change from base Build 018fa998-47fc-455c-b90b-e123465c249a: -0.2%
Covered Lines: 102091
Relevant Lines: 147336

💛 - Coveralls

@jakobht jakobht merged commit 96c47bc into cadence-workflow:master May 24, 2024
20 checks passed
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants