Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for mutable_state_builder_methods_signal.go #6056

Merged
merged 4 commits into from
May 24, 2024

Conversation

sankari165
Copy link
Member

What changed?
unit tests added for mutable_state_builder_methods_signal.go

Why?
improve code coverage

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.76%. Comparing base (fb4bfce) to head (a0c80cf).
Report is 6 commits behind head on master.

Additional details and impacted files

see 18 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb4bfce...a0c80cf. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018fa9e3-7c7c-4a51-a84e-85f8669f2ae7

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 324 unchanged lines in 22 files lost coverage.
  • Overall coverage decreased (-0.1%) to 69.294%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 88.06%
common/persistence/execution_manager.go 2 86.43%
service/matching/tasklist/task_list_manager.go 2 76.09%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/history/execution/mutable_state_builder.go 2 78.45%
service/history/execution/mutable_state_util.go 2 78.52%
common/persistence/statsComputer.go 2 97.14%
service/matching/tasklist/matcher.go 2 89.35%
service/matching/tasklist/task_reader.go 2 77.45%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
Totals Coverage Status
Change from base Build 018fa77b-4f9b-42ed-a8a3-efd0d12a5a8a: -0.1%
Covered Lines: 102095
Relevant Lines: 147336

💛 - Coveralls

@sankari165 sankari165 merged commit 307ae80 into cadence-workflow:master May 24, 2024
20 checks passed
@sankari165 sankari165 deleted the CDNC-8897 branch May 24, 2024 09:56
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
…orkflow#6056)

* Add unit tests for mutable_state_builder_methods_signal.go

* Update mutable_state_builder_methods_signal_test.go

* Update mutable_state_builder_methods_signal_test.go

* fix lint issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants