Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for DescribeMutableState #6059

Merged

Conversation

jakobht
Copy link
Member

@jakobht jakobht commented May 24, 2024

What changed?
Added tests for DescribeMutable State

Why?
Improve coverage

How did you test it?

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.03%. Comparing base (8d5c056) to head (18e66ae).
Report is 2 commits behind head on master.

Additional details and impacted files

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d5c056...18e66ae. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018fb8d7-af34-46ef-b0c3-4cb6e1886514

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 29 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.03%) to 69.512%

Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.66%
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
service/matching/tasklist/task_list_manager.go 2 76.09%
service/history/queue/transfer_queue_processor.go 2 56.07%
service/matching/tasklist/matcher.go 2 89.35%
common/task/fifo_task_scheduler.go 3 82.47%
service/frontend/api/handler.go 4 62.26%
service/frontend/wrappers/metered/metered.go 4 66.67%
service/history/engine/engineimpl/poll_mutable_state.go 9 74.16%
Totals Coverage Status
Change from base Build 018faadd-0f68-4f46-a937-a0c09b154ebd: 0.03%
Covered Lines: 102473
Relevant Lines: 147418

💛 - Coveralls

@jakobht jakobht merged commit 7a58a5d into cadence-workflow:master May 28, 2024
20 checks passed
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants