-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code-coverage] Add tests for history decision task handler #6060
[code-coverage] Add tests for history decision task handler #6060
Conversation
c7c1d27
to
ed57461
Compare
ed57461
to
22bfd07
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Pull Request Test Coverage Report for Build 018fabc6-df68-4d1a-b108-9517f6a6deb1Details
💛 - Coveralls |
expectMockCalls: func(taskHandler *taskHandlerImpl, attr *types.CancelWorkflowExecutionDecisionAttributes) { | ||
taskHandler.hasUnhandledEventsBeforeDecisions = true | ||
}, | ||
asserts: func(t *testing.T, taskHandler *taskHandlerImpl, attr *types.CancelWorkflowExecutionDecisionAttributes, err error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very fancy, easy to read though, nice!
Introduced the following tests in service/history/decision: TestHandleDecisionRecordMarker TestHandleDecisionScheduleActivity TestHandleDecisionCancelWorkflow
What changed?
Introduced the following tests in service/history/decision:
TestHandleDecisionRecordMarker
TestHandleDecisionScheduleActivity
TestHandleDecisionCancelWorkflow
Why?
improve code coverage in the package
How did you test it?
unit tests
Potential risks
Release notes
Documentation Changes