Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ListAllWorkflowExecutions method in frontend #6065

Merged
merged 4 commits into from
May 31, 2024

Conversation

sankari165
Copy link
Member

What changed?
ListAllWorkflowExecutions method in frontend api

Why?
To be able to list all workflow executions with partial search support

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018fc427-fc6f-4e0d-890d-e517fbee710b

Details

  • 92 of 165 (55.76%) changed or added relevant lines in 10 files are covered.
  • 55 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-0.03%) to 69.493%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/wrappers/sampled/visibility_manager.go 0 5 0.0%
common/persistence/elasticsearch/es_visibility_metric_clients.go 0 13 0.0%
common/persistence/pinot/pinot_visibility_metric_clients.go 0 13 0.0%
service/frontend/api/handler.go 50 67 74.63%
common/types/shared.go 0 25 0.0%
Files with Coverage Reduction New Missed Lines %
common/cache/lru.go 2 92.89%
service/history/replication/task_processor.go 2 81.25%
service/history/task/transfer_active_task_executor.go 2 72.72%
common/util.go 2 91.78%
service/history/task/fetcher.go 2 85.05%
service/history/task/task.go 3 84.81%
service/history/handler/handler.go 3 96.2%
tools/cli/admin_db_decode_thrift.go 3 69.23%
service/matching/tasklist/task_list_manager.go 4 76.09%
service/frontend/api/handler.go 4 62.51%
Totals Coverage Status
Change from base Build 018facb4-1556-4d0a-a60a-2fec545c95e9: -0.03%
Covered Lines: 102602
Relevant Lines: 147644

💛 - Coveralls

Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 62.85714% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 68.14%. Comparing base (2f08de5) to head (0f3bc98).
Report is 4 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
...mon/persistence/dataVisibilityManagerInterfaces.go 0.00% <ø> (ø)
...ommon/persistence/pinot_visibility_dual_manager.go 100.00% <100.00%> (ø)
...mon/persistence/pinot_visibility_triple_manager.go 100.00% <100.00%> (ø)
common/persistence/visibility_dual_manager.go 100.00% <100.00%> (ø)
common/persistence/visibility_single_manager.go 99.21% <100.00%> (+0.03%) ⬆️
...ommon/persistence/wrappers/errorinjectors/utils.go 93.97% <100.00%> (+0.04%) ⬆️
...persistence/wrappers/sampled/visibility_manager.go 77.77% <0.00%> (-2.76%) ⬇️
...ence/elasticsearch/es_visibility_metric_clients.go 0.00% <0.00%> (ø)
...rsistence/pinot/pinot_visibility_metric_clients.go 95.05% <0.00%> (-4.95%) ⬇️
service/frontend/api/handler.go 40.10% <66.00%> (+0.50%) ⬆️

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f08de5...0f3bc98. Read the comment docs.

Copy link
Member

@3vilhamster 3vilhamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits, but LGTM

},
)

wh.GetLogger().Debug("List all workflows",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: not sure why this log is here.
I would expect if err != nil to be right after wh.GetVisibilityManager().ListAllWorkflowExecutions(

ctx context.Context,
request *p.ListAllWorkflowExecutionsRequest,
) (*p.ListWorkflowExecutionsResponse, error) {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Should it be exempted from code coverage?

@sankari165 sankari165 merged commit f3ef924 into cadence-workflow:master May 31, 2024
20 checks passed
@sankari165 sankari165 deleted the CDNC-7938 branch May 31, 2024 10:50
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
…low#6065)

* Introduce ListAllWorkflowExecutions method in frontend

* Update defs.go

* fix lint issues

* update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants