Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for shard context #6087

Conversation

taylanisikdemir
Copy link
Member

@taylanisikdemir taylanisikdemir commented Jun 3, 2024

What changed?
Wrote tests for some part of history/shard/context.go

Why?
Improve coverage

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 42 lines in your changes missing coverage. Please review.

Project coverage is 68.81%. Comparing base (ab0d875) to head (bd5eca7).

Current head bd5eca7 differs from pull request most recent head ad3e37a

Please upload reports for the commit ad3e37a to get more accurate results.

Additional details and impacted files
Files Coverage Δ
service/history/shard/test_context.go 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab0d875...ad3e37a. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 4, 2024

Pull Request Test Coverage Report for Build 018fe4bc-3b62-4bdb-b2eb-3f37bf730fab

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 46 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.02%) to 70.215%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
service/matching/tasklist/db.go 2 73.23%
common/task/fifo_task_scheduler.go 2 80.41%
common/membership/hashring.go 2 84.69%
common/persistence/historyManager.go 2 66.67%
common/log/tag/tags.go 3 50.46%
common/persistence/nosql/nosql_task_store.go 3 85.52%
common/types/history.go 4 45.35%
service/history/engine/engineimpl/record_activity_task_started.go 4 68.87%
service/frontend/api/handler.go 4 65.45%
Totals Coverage Status
Change from base Build 018fe451-cd64-44f5-8cb8-8b9c6b71f4ba: 0.02%
Covered Lines: 104585
Relevant Lines: 148950

💛 - Coveralls

@taylanisikdemir taylanisikdemir merged commit 265fde7 into cadence-workflow:master Jun 4, 2024
18 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/shard_context_tests.go branch June 4, 2024 21:15
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 4, 2024
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 4, 2024
dkrotx pushed a commit to dkrotx/cadence that referenced this pull request Jun 5, 2024
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants