Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for mutable_state_builder_methods_child_workflow #6088

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

natemort
Copy link
Member

@natemort natemort commented Jun 3, 2024

What changed?

  • Increased test coverage from 1% to 89%

Why?

  • Increasing test coverage

How did you test it?

  • Unit tests

Potential risks

  • None, this change is test only.

Release notes

Documentation Changes

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.84%. Comparing base (4cc5736) to head (b5eac1f).
Report is 4 commits behind head on master.

Additional details and impacted files

see 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af66f14...b5eac1f. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018fe04c-c35c-464d-a850-d522171861a2

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 35 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.2%) to 69.897%

Files with Coverage Reduction New Missed Lines %
service/history/execution/mutable_state_util.go 2 78.52%
service/matching/tasklist/matcher.go 2 88.66%
common/types/history.go 4 45.35%
service/history/task/transfer_standby_task_executor.go 5 87.55%
service/history/task/fetcher.go 5 85.57%
service/history/task/cross_cluster_task_processor.go 8 80.79%
service/history/engine/engineimpl/record_activity_task_started.go 9 68.87%
Totals Coverage Status
Change from base Build 018fe042-ab11-41df-a347-75d7690ef633: 0.2%
Covered Lines: 103403
Relevant Lines: 147936

💛 - Coveralls

@natemort natemort merged commit e62abf5 into cadence-workflow:master Jun 4, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants