Refactor high-coupling method into functions in applyEvent for a more testability #6089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenxia
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
bowenxia
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Shaddoll
reviewed
Jun 3, 2024
| newStateBuilder stateBuilderProvider | ||
| newMutableState mutableStateProvider | ||
| newReplicationTaskFn newReplicationTaskFn | ||
| newBranchManager branchManagerProvider |
There was a problem hiding this comment.
Can you add Fn suffix to these function parameters?
bowenxia
commented
Jun 4, 2024
| } | ||
| return r.applyNonStartEventsToNoneCurrentBranch(ctx, context, mutableState, branchIndex, releaseFn, task) | ||
| // passed in r because there's a recursive call within applyNonStartEventsToNoneCurrentBranchWithContinueAsNew | ||
| return r.applyNonStartEventsToNoneCurrentBranchFn(ctx, context, mutableState, branchIndex, releaseFn, task, r) |
There was a problem hiding this comment.
I'm not sure if I could do this here. It is actually a recursive call. If I change this applyEvents method to be a function, there would be too many things to be passed in into this function.
| newStateBuilder stateBuilderProvider | ||
| newMutableState mutableStateProvider | ||
| newReplicationTaskFn newReplicationTaskFn | ||
| newBranchManager branchManagerProvider |
Shaddoll
approved these changes
Jun 4, 2024
Pull Request Test Coverage Report for Build 018fe0a0-cddd-4e8a-9e06-8a5a8650a29cDetails
💛 - Coveralls |
timl3136
pushed a commit
to timl3136/cadence
that referenced
this pull request
Jun 6, 2024
… testability (cadence-workflow#6089) * refactor coupled functions for a more testability * renaming old functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Refactored methods in applyEvent to be functions, and make them as historyReplicator parameters
Why?
Easier to do unit test
How did you test it?
Potential risks
Release notes
Documentation Changes