Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for RespondActivityTaskFailedByID in frontend API handler #6091

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

timl3136
Copy link
Member

@timl3136 timl3136 commented Jun 4, 2024

What changed?
Add unit tests for RespondActivityTaskFailedByID in frontend api handler

Why?
Improve test coverage and stability

How did you test it?
Unit tests

Potential risks

Release notes

Documentation Changes

@timl3136 timl3136 enabled auto-merge (squash) June 4, 2024 17:10
@timl3136 timl3136 merged commit ab0d875 into cadence-workflow:master Jun 4, 2024
18 checks passed
@timl3136 timl3136 deleted the frontend-handler-test branch June 4, 2024 17:35
@coveralls
Copy link

coveralls commented Jun 4, 2024

Pull Request Test Coverage Report for Build 018fe099-4d86-443c-bab5-7ae16970a85d

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 182 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-0.04%) to 69.738%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/history/task/transfer_active_task_executor.go 2 72.79%
common/util.go 2 91.78%
service/history/task/fetcher.go 2 85.57%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
service/history/handler/handler.go 3 96.2%
common/task/fifo_task_scheduler.go 3 84.54%
common/archiver/filestore/historyArchiver.go 4 80.95%
service/history/task/transfer_standby_task_executor.go 6 86.33%
Totals Coverage Status
Change from base Build 018fe051-df14-4702-b515-0388c6db07f3: -0.04%
Covered Lines: 103168
Relevant Lines: 147936

💛 - Coveralls

timl3136 added a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants