We now only log "Failed to signal external workflow execution" on unexpected errors #6092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobht
force-pushed
the
failed_to_signal_error
branch
from
66a9b18
to
4978366
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 38 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
jakobht
force-pushed
the
failed_to_signal_error
branch
from
4978366
to
3c87e0b
Compare
We have a log of "Failed to signal extermal workflow execution" error logs in server with the error being "workflow execution already completed". This is an expected state so we should not log errors for this. Additionally we add transient errors and not exists errors to the things we should not log errors for, as they are expected in the normal operation of the system.
jakobht
force-pushed
the
failed_to_signal_error
branch
from
3c87e0b
to
cd77fe7
Compare
Pull Request Test Coverage Report for Build 018fe297-243a-428e-aaa9-0bec8e4c63b4Details
💛 - Coveralls |
jakobht
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
3vilhamster
approved these changes
Jun 4, 2024
timl3136
pushed a commit
to timl3136/cadence
that referenced
this pull request
Jun 6, 2024
…kflow#6092) We have a log of "Failed to signal extermal workflow execution" error logs in server with the error being "workflow execution already completed". This is an expected state so we should not log errors for this. Additionally we add transient errors and not exists errors to the things we should not log errors for, as they are expected in the normal operation of the system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
We now only log "Failed to signal external workflow execution" for unexpected errors. Expected errors are defined as transient errors, not exists errors and "workflow execution already completed" errors.
Why?
We have a lot of "Failed to signal extermal workflow execution" error
logs in server with the error being "workflow execution already
completed".
This is an expected state so we should not log errors for this.
Additionally we add transient errors and not exists errors to the things we
should not log errors for, as they are expected in the normal operation
of the system.
How did you test it?
Unit tests
Potential risks
Release notes
Documentation Changes